Add missing function `value` for TabBar

ronisbr commented

2026-03-19 06:46:36 -07:00

(Migrated from github.com)

The function value for TabBar is mentioned in the docs (https://kahliburke.github.io/Tachikoma.jl/dev/widgets#TabBar) but it was not implemented. This PR adds the function and test.

Hi @kahliburke ! The function `value` for TabBar is mentioned in the docs (https://kahliburke.github.io/Tachikoma.jl/dev/widgets#TabBar) but it was not implemented. This PR adds the function and test.

ronisbr commented

2026-03-19 06:50:41 -07:00

(Migrated from github.com)

BTW, handle_key is also not implemented for TabBar but I am not sure what keys do you want to use by default.

BTW, `handle_key` is also not implemented for TabBar but I am not sure what keys do you want to use by default.

ronisbr commented

2026-03-19 06:55:37 -07:00

(Migrated from github.com)

However, I am thinking that since TabBar is immutable and the active tab must be known when it was created, maybe this function must not be implemented. In this case, we should remove it from the docs :)

ronisbr commented

2026-03-19 14:21:42 -07:00

(Migrated from github.com)

After thinking about it, I think we should just remove this from the docs! There is not need to have this function given how tab bars are built.

kahliburke commented

2026-03-19 17:36:36 -07:00

(Migrated from github.com)

@ronisbr although you closed this, I feel it surfaced a problem in the code that should be addressed. The tab bar got lost in the shuffle it seems and I realized that a couple projects I have were reimplementing functionality which should really be built in.

So I've made the changes. I believe it should still be compatible with the old method, so it will be a patch release, but the functionality is improved and it should be very easy to migrate to the new system. So this will come in 1.1.5

@ronisbr although you closed this, I feel it surfaced a problem in the code that should be addressed. The tab bar got lost in the shuffle it seems and I realized that a couple projects I have were reimplementing functionality which should really be built in. So I've made the changes. I believe it should still be compatible with the old method, so it will be a patch release, but the functionality is improved and it should be very easy to migrate to the new system. So this will come in 1.1.5

❤️ 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Rows
Columns

Add missing function value for TabBar #22

Pull request closed

Add missing function `value` for TabBar #22