Demos do not show cursor #25
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
kahliburke/Tachikoma.jl#25
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The "terminal" and "repl" demos do not show a cursor.
I am using WezTerm, the "paper" theme, and I have a light background.
I will take a look at this, do you think it's specifically a light theme-centric issue?
I don't know, I don't think so, but I wanted to give as much information as necessary. Maybe the cursor is set to "white block" and then I wouldn't have seen it.
Fixed in d4c4e0e on
main— the cursor color inversion was using hardcodedColor256(0)/Color256(7)as fallbacks when cell colors were unset. On light themes (like Paper) these produce a nearly-invisible cursor against the terminal background.The fix uses
theme().bgandtheme().textinstead, which adapt to whichever theme is active. Should work correctly on both dark and light backgrounds now.This fix will also be included in the upcoming Tachikoma 2.0 release.
@eschnett, should be fixed, care to try it and let me know if it works for you now?
It's working!
Fixed in d4c4e0e (main) and
dfdf221(dev/v2.0-preview).