Fix Windows crash: guard POSIX dup() call in app() #12
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
kahliburke/Tachikoma.jl!12
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/11-windows-dup-ccall"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
ccall(:dup, ...)inapp()with@static if Sys.iswindows(), falling back tostdindirectlydupis POSIX-only and crashes immediately on Windows with "could not load symbol"dupis only needed to preserve the real terminal fd before REPLWidget redirects stdin, but REPLWidget requires PTY and can't run on Windows anywayTest plan
Fixes #11
Just tested this with the Life app on Julia 1.10.11 for win11.
Seems to work ok. (Any reason why the squares in the Life cells
are not ... square?)
@devel-chm Thanks for testing ... generally things are built out of terminal characters which are not square. The pixel graphic support with Sixel and kitty allow you to skirt around this. Here's what I see when I run it:
I was able to install version 1.1.3 on julia 1.10.11 with windows11 and I was able to figure out how
to access the demos and run the launch. Thats progress, thanks!